Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(110)

Issue 5727055: Various updates to reduce make doc output (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by PhilEHolmes
Modified:
12 years ago
Reviewers:
dak, mail, Graham Percival, Julien Rioux, t.daniels, email
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

GNUmakefile: pushes lilypond output to a logfile. GNUmakefile.in: heeltap from previous patch lilypond-book-rules.make: removes output from pdflatex and prevents it requesting input if it fails. lysdoc-rules.make: Gets rid of echoed progress message abc2ly.py; lys-to-tely.py; midi2ly.py: Gets rid of progress message using a --quiet flag.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Updates as suggested #

Patch Set 3 : Update to GNUmakefile #

Patch Set 4 : --quiet added to abc2ly and midi2ly #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -42 lines) Patch
M Documentation/GNUmakefile View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M GNUmakefile.in View 1 chunk +0 lines, -4 lines 0 comments Download
M make/abc-rules.make View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M make/lilypond-book-rules.make View 1 chunk +1 line, -1 line 0 comments Download
M make/lysdoc-rules.make View 1 chunk +0 lines, -1 line 0 comments Download
M make/midi-rules.make View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/abc2ly.py View 1 5 chunks +23 lines, -13 lines 2 comments Download
M scripts/build/lys-to-tely.py View 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/midi2ly.py View 1 4 chunks +19 lines, -16 lines 2 comments Download

Messages

Total messages: 17
PhilEHolmes
Now down to less than 500 lines with these changes. Please review.
12 years ago (2012-03-04 16:21:21 UTC) #1
Julien Rioux
I think the scrips abc2ly and midi2ly are useful as stand-alone tools, i.e. outside of ...
12 years ago (2012-03-04 16:50:20 UTC) #2
mail_philholmes.net
----- Original Message ----- From: <julien.rioux@gmail.com> To: <PhilEHolmes@googlemail.com>; <dak@gnu.org>; <graham@percival-music.ca> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Sunday, ...
12 years ago (2012-03-04 17:04:28 UTC) #3
Julien Rioux
On Sun, Mar 4, 2012 at 12:04 PM, Phil Holmes <mail@philholmes.net> wrote: > ----- Original ...
12 years ago (2012-03-04 18:05:07 UTC) #4
Graham Percival
On 2012/03/04 16:50:20, Julien Rioux wrote: > I think the scrips abc2ly and midi2ly are ...
12 years ago (2012-03-04 21:59:42 UTC) #5
PhilEHolmes
Updates as suggested. Please review.
12 years ago (2012-03-11 16:54:11 UTC) #6
PhilEHolmes
--quiet flag added to abc2ly and midi2ly invocations. make and make doc compile clean. Will ...
12 years ago (2012-03-12 16:32:53 UTC) #7
Julien Rioux
--quiet shouldn't suppress warning messages, everything else looks good. Cheers, Julien http://codereview.appspot.com/5727055/diff/11002/scripts/midi2ly.py File scripts/midi2ly.py (right): ...
12 years ago (2012-03-12 18:18:34 UTC) #8
mail_philholmes.net
----- Original Message ----- From: <julien.rioux@gmail.com> To: <PhilEHolmes@googlemail.com>; <dak@gnu.org>; <graham@percival-music.ca>; <mail@philholmes.net> Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com> Sent: ...
12 years ago (2012-03-12 18:31:48 UTC) #9
Graham Percival
On Mon, Mar 12, 2012 at 06:31:35PM -0000, Phil Holmes wrote: > ----- Original Message ...
12 years ago (2012-03-12 19:27:15 UTC) #10
Julien Rioux
Maybe simply... http://codereview.appspot.com/5727055/diff/11002/scripts/abc2ly.py File scripts/abc2ly.py (right): http://codereview.appspot.com/5727055/diff/11002/scripts/abc2ly.py#newcode1400 scripts/abc2ly.py:1400: help=_ ("suppress progress messages")) ..change this to ...
12 years ago (2012-03-12 19:43:37 UTC) #11
email_philholmes.net
----- Original Message ----- From: "Graham Percival" <graham@percival-music.ca> To: "Phil Holmes" <mail@philholmes.net> Cc: <PhilEHolmes@googlemail.com>; <dak@gnu.org>; ...
12 years ago (2012-03-12 22:26:47 UTC) #12
Julien Rioux
On Mon, Mar 12, 2012 at 6:26 PM, Phil Holmes <email@philholmes.net> wrote: > ----- Original ...
12 years ago (2012-03-13 19:14:29 UTC) #13
email_philholmes.net
----- Original Message ----- From: "Julien Rioux" <julien.rioux@gmail.com> To: "Phil Holmes" <email@philholmes.net> > > > ...
12 years ago (2012-03-14 08:56:33 UTC) #14
Julien Rioux
On Wed, Mar 14, 2012 at 9:56 AM, Phil Holmes <email@philholmes.net> wrote: > ----- Original ...
12 years ago (2012-03-14 10:37:38 UTC) #15
t.daniels_treda.co.uk
Julien Rioux wrote Wednesday, March 14, 2012 10:37 AM > On Wed, Mar 14, 2012 ...
12 years ago (2012-03-14 11:41:16 UTC) #16
Graham Percival
12 years ago (2012-03-16 05:26:54 UTC) #17
ok

http://codereview.appspot.com/5727055/diff/11002/scripts/abc2ly.py
File scripts/abc2ly.py (right):

http://codereview.appspot.com/5727055/diff/11002/scripts/abc2ly.py#newcode1400
scripts/abc2ly.py:1400: help=_ ("suppress progress messages"))
On 2012/03/12 19:43:38, Julien Rioux wrote:
> ..change this to "suppress progress and warning messages"?

+1

http://codereview.appspot.com/5727055/diff/11002/scripts/midi2ly.py
File scripts/midi2ly.py (right):

http://codereview.appspot.com/5727055/diff/11002/scripts/midi2ly.py#newcode1078
scripts/midi2ly.py:1078: help=_ ("suppress progress messages"))
change to "suppress progress messages and warnings"
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b