Issue 5727044: Better workaround for osx / nv bug

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5727044: Better workaround for osx / nv bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by bsalomon

Modified:
12 years, 8 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -59 lines)			Patch
M	include/gpu/gl/GrGLConfig.h	View	2 chunks	+7 lines, -11 lines	0 comments	Download
M	src/gpu/gl/GrGLIndexBuffer.cpp	View	1 chunk	+21 lines, -29 lines	0 comments	Download
M	src/gpu/gl/GrGLVertexBuffer.cpp	View	1 chunk	+29 lines, -19 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

lgtm + possible comment + possible link to extern bug? http://codereview.appspot.com/5727044/diff/1/src/gpu/gl/GrGLVertexBuffer.cpp File src/gpu/gl/GrGLVertexBuffer.cpp (right): http://codereview.appspot.com/5727044/diff/1/src/gpu/gl/GrGLVertexBuffer.cpp#newcode126 ...

12 years, 8 months ago (2012-03-02 20:32:56 UTC) #2

bsalomon

12 years, 8 months ago (2012-03-02 20:37:17 UTC) #3

Closed with r3308.

On 2012/03/02 20:32:56, reed1 wrote:
> lgtm + possible comment + possible link to extern bug?
>

The big comment in GrGLConfig.h has a link to the bug.

 
> http://codereview.appspot.com/5727044/diff/1/src/gpu/gl/GrGLVertexBuffer.cpp
> File src/gpu/gl/GrGLVertexBuffer.cpp (right):
> 
>
http://codereview.appspot.com/5727044/diff/1/src/gpu/gl/GrGLVertexBuffer.cpp#...
> src/gpu/gl/GrGLVertexBuffer.cpp:126: static int N = 0;
> // Here why I use 128...

Done.

Expand All Messages | Collapse All Messages