Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(221)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 572640043: Use new syntax throughout the doc and examples

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by Valentin Villenave
Modified:
5 years, 10 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Use new syntax throughout the doc and examples This patch is inspired by Harm’s recent work on issue #5509. (I’ve also catched a bunch of those all over the LSR, so these should be updated by makelsr at some point.)

Patch Set 1 #

Total comments: 2

Patch Set 2 : spaces not tabs… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -89 lines) Patch
M Documentation/contributor/programming-work.itexi View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/cs/learning/tweaks.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/de/notation/changing-defaults.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/de/notation/rhythms.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/fr/learning/tweaks.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ja/notation/changing-defaults.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ja/notation/rhythms.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/music-glossary.tely View 19 chunks +51 lines, -51 lines 0 comments Download
M Documentation/notation/spacing.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/fingering-adjacent-note-chord-new.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/instrument-name-x-align.ly View 1 chunk +1 line, -1 line 0 comments Download
M lily/beam.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/cluster.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/paper-column.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ly/turkish-makam.ly View 1 chunk +1 line, -1 line 0 comments Download
M python/musicexp.py View 5 chunks +8 lines, -8 lines 0 comments Download
M scm/define-markup-commands.scm View 1 1 chunk +5 lines, -6 lines 0 comments Download
M scm/harp-pedals.scm View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5
thomasmorley651
LGTM Some nit below Thanks, Harm https://codereview.appspot.com/572640043/diff/552640043/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/572640043/diff/552640043/scm/define-markup-commands.scm#newcode1310 scm/define-markup-commands.scm:1310: #'(time-signature key-signature) tab ...
6 years ago (2019-04-25 16:04:34 UTC) #1
Valentin Villenave
spaces not tabs…
6 years ago (2019-04-25 21:27:39 UTC) #2
lilypond-pkx
Patch counted down - please push
5 years, 10 months ago (2019-06-19 05:52:42 UTC) #3
lilypond-pkx
On 2019/04/25 21:27:39, Valentin Villenave wrote: > spaces not tabs… Patch counted down - please ...
5 years, 10 months ago (2019-07-09 17:44:01 UTC) #4
lilypond-pkx
5 years, 10 months ago (2019-07-14 12:10:56 UTC) #5 
This was stuck as 'please push' for weeks. I have retested the patch today and
am pushing it on VV's behalf - seems a shame to waste the work otherwise.

Doc: Use new syntax throughout all doc and examples staging
author  Valentin Villenave <valentin@villenave.net> 
    Sun, 14 Jul 2019 13:02:02 +0100 (13:02 +0100)
committer   James Lowe <pkx166h@runbox.com> 
    Sun, 14 Jul 2019 13:07:17 +0100 (13:07 +0100)
commit  47f74e11cfdf3f7dfa54ca0b1d009da770d6aef5
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b