Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1924)

Issue 5722046: Remove SkImageDecoder_libjpeg and all references to it (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by TomH
Modified:
12 years, 9 months ago
Reviewers:
epoger, bsalomon, reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Per Elliot's investigations, we have never built SkImageDecoder_libjpeg since we started building with gyp. Asking Brian to review since that original gyp commit was his - why did we explicitly exclude the libjpeg decoder on every platform? Resolve http://code.google.com/p/skia/issues/detail?id=52 by removing dead code from the library.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -647 lines) Patch
M gyp/images.gyp View 5 chunks +0 lines, -5 lines 0 comments Download
D src/images/SkImageDecoder_libjpeg.cpp View 1 chunk +0 lines, -642 lines 0 comments Download

Messages

Total messages: 6
TomH
12 years, 9 months ago (2012-03-02 15:05:36 UTC) #1
bsalomon
I'm sure I just copied that from chromium's skia.gyp which must use its own jpeg ...
12 years, 9 months ago (2012-03-02 15:10:18 UTC) #2
TomH
On 2012/03/02 15:10:18, bsalomon wrote: > Adding Mike because I'm not sure if the src ...
12 years, 9 months ago (2012-03-02 15:13:53 UTC) #3
epoger
LGTM I didn't know about http://code.google.com/p/skia/issues/detail?id=52 ('Add casting to char to avoid compiler warnings') ...
12 years, 9 months ago (2012-03-02 15:14:19 UTC) #4
bsalomon
On 2012/03/02 15:14:19, epoger wrote: > LGTM > > I didn't know about http://code.google.com/p/skia/issues/detail?id=52 ('Add ...
12 years, 9 months ago (2012-03-02 15:18:40 UTC) #5
TomH
12 years, 9 months ago (2012-03-02 15:38:38 UTC) #6
Closed with r3302.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b