As discussed, OSAA code is removed. For chromium, it sets GR_USE_OFFSCREEN_AA to 0, but for ...
12 years, 9 months ago
(2012-03-02 00:58:36 UTC)
#1
As discussed, OSAA code is removed. For chromium, it sets GR_USE_OFFSCREEN_AA to
0, but for GM test, it still uses OSAA code, so with this CL, we have to
rebaseline GM.
It's all red, no green. :) Please review. thanks!
On 2012/03/02 00:58:36, guanqun wrote: > As discussed, OSAA code is removed. For chromium, it ...
12 years, 9 months ago
(2012-03-02 16:42:06 UTC)
#2
On 2012/03/02 00:58:36, guanqun wrote:
> As discussed, OSAA code is removed. For chromium, it sets GR_USE_OFFSCREEN_AA
to
> 0, but for GM test, it still uses OSAA code, so with this CL, we have to
> rebaseline GM.
>
> It's all red, no green. :) Please review. thanks!
It LGTM. There is an additional line that can be removed (prAA = false; in
drawPath). I'm testing it now. The 4x4 downsample filter could be removed since
AFAIK only the OSAA code used it. But I'm wondering if the blur code could take
advantage of it so let's leave it for now. I'm testing locally and if it looks
good I'll check it in and rebaseline.
On 2012/03/02 16:42:06, bsalomon wrote: > On 2012/03/02 00:58:36, guanqun wrote: > > As discussed, ...
12 years, 9 months ago
(2012-03-02 21:25:38 UTC)
#3
On 2012/03/02 16:42:06, bsalomon wrote:
> On 2012/03/02 00:58:36, guanqun wrote:
> > As discussed, OSAA code is removed. For chromium, it sets
GR_USE_OFFSCREEN_AA
> to
> > 0, but for GM test, it still uses OSAA code, so with this CL, we have to
> > rebaseline GM.
> >
> > It's all red, no green. :) Please review. thanks!
>
> It LGTM. There is an additional line that can be removed (prAA = false; in
> drawPath). I'm testing it now. The 4x4 downsample filter could be removed
since
> AFAIK only the OSAA code used it. But I'm wondering if the blur code could
take
> advantage of it so let's leave it for now. I'm testing locally and if it looks
> good I'll check it in and rebaseline.
Landed as r3305
Issue 5722044: remove OSAA code in GrContext
(Closed)
Created 12 years, 9 months ago by guanqun
Modified 12 years, 9 months ago
Reviewers: bsalomon
Base URL: http://skia.googlecode.com/svn/trunk
Comments: 0