Issue 5722044: remove OSAA code in GrContext

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5722044: remove OSAA code in GrContext (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by guanqun

Modified:
12 years, 10 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

remove OSAA code in GrContext This CL needs to generate new GM baseline. BUG= TEST=

Patch Set 1 #

Patch Set 2 : cleanup in gpu.gyp #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -343 lines)			Patch
M	gyp/gpu.gyp	View	1	2 chunks	+0 lines, -10 lines	0 comments	Download
M	include/gpu/GrConfig.h	View		1 chunk	+0 lines, -17 lines	0 comments	Download
M	include/gpu/GrContext.h	View		2 chunks	+0 lines, -34 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View		6 chunks	+0 lines, -282 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

guanqun

As discussed, OSAA code is removed. For chromium, it sets GR_USE_OFFSCREEN_AA to 0, but for ...

12 years, 10 months ago (2012-03-02 00:58:36 UTC) #1

bsalomon

On 2012/03/02 00:58:36, guanqun wrote: > As discussed, OSAA code is removed. For chromium, it ...

12 years, 10 months ago (2012-03-02 16:42:06 UTC) #2

bsalomon

12 years, 10 months ago (2012-03-02 21:25:38 UTC) #3

On 2012/03/02 16:42:06, bsalomon wrote:
> On 2012/03/02 00:58:36, guanqun wrote:
> > As discussed, OSAA code is removed. For chromium, it sets
GR_USE_OFFSCREEN_AA
> to
> > 0, but for GM test, it still uses OSAA code, so with this CL, we have to
> > rebaseline GM.
> > 
> > It's all red, no green. :) Please review. thanks!
> 
> It LGTM. There is an additional line that can be removed (prAA = false; in
> drawPath). I'm testing it now. The 4x4 downsample filter could be removed
since
> AFAIK only the OSAA code used it. But I'm wondering if the blur code could
take
> advantage of it so let's leave it for now. I'm testing locally and if it looks
> good I'll check it in and rebaseline.

Landed as r3305

Expand All Messages | Collapse All Messages