Fix cycling through buffers in buffer alloc pool

[bsalomon, 2012-03-01 16:43:17]

The intent was to cycle through the set of preallocated buffers in the pool. So
if in a given run we use buffers 0, 1, and 2, then after a reset we'd start with
3. 

However, the variable I use to know how many buffers were used before the reset
is decremented down to zero by the time I read it. Also, I didn't consider the
case where the caller reserved space but never used it and returns in putBack().

[TomH, 2012-03-01 17:05:14]

http://codereview.appspot.com/5716050/diff/1/src/gpu/GrBufferAllocPool.cpp
File src/gpu/GrBufferAllocPool.cpp (right):

http://codereview.appspot.com/5716050/diff/1/src/gpu/GrBufferAllocPool.cpp#ne...
src/gpu/GrBufferAllocPool.cpp:93: fPreallocBuffersInUse) %
Comment in line 85 suggests that this will always be 0?
Do you mean to use preallocBuffersInUse here?

http://codereview.appspot.com/5716050/diff/1/src/gpu/GrBufferAllocPool.cpp#ne...
src/gpu/GrBufferAllocPool.cpp:251: fPreallocBuffersInUse) %
Again, you're setting preallocBuffersInUse in 226 and not using it anywhere -
bug?

[bsalomon, 2012-03-01 19:41:20]

http://codereview.appspot.com/5716050/diff/1/src/gpu/GrBufferAllocPool.cpp
File src/gpu/GrBufferAllocPool.cpp (right):

http://codereview.appspot.com/5716050/diff/1/src/gpu/GrBufferAllocPool.cpp#ne...
src/gpu/GrBufferAllocPool.cpp:93: fPreallocBuffersInUse) %
On 2012/03/01 17:05:14, TomH wrote:
> Comment in line 85 suggests that this will always be 0?
> Do you mean to use preallocBuffersInUse here?

Yes, I'm a moron :)

[TomH, 2012-03-01 20:42:59]

LGTM

[bsalomon, 2012-03-01 20:59:46]

closed with r3296