Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(438)

Issue 571420055: Tiny fixes for extractpdfmark (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by hahnjo
Modified:
4 years, 2 months ago
Reviewers:
Dan Eble, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Tiny fixes for extractpdfmark Individual changes: 1) Fix extractpdfmark not coming from PATH If STEPMAKE_PROGS cannot find an optional program, it returns "false". Checking for this value is better than requiring exactly "extractpdfmark" which does not hold if the program is not in PATH and the user explicitly sets the environment variable EXTRACTPDFMARK. 2) Fix extractpdfmark with GhostScript 9.50 GhostScript 9.50 defaults to -dSAFE, so the build system needs to pas in -dNOSAFE explicitly. 3) Update message for optional extractpdfmark From my experiments, enabling extractpdfmark rather increases the required disk space. This is probably because the process produces additional intermediate files. It only benefits the final PDF docs.

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebase and adapt message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M configure.ac View 1 1 chunk +3 lines, -5 lines 0 comments Download
M make/lilypond-book-rules.make View 2 chunks +2 lines, -0 lines 0 comments Download
M stepmake/stepmake/texinfo-rules.make View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
lemzwerg
LGTM, thanks https://codereview.appspot.com/571420055/diff/571400046/configure.ac File configure.ac (right): https://codereview.appspot.com/571420055/diff/571400046/configure.ac#newcode391 configure.ac:391: ["(Using Ghostscript >= 9.20 together with Extract ...
4 years, 3 months ago (2020-01-25 09:15:11 UTC) #1
hahnjo
https://codereview.appspot.com/571420055/diff/571400046/configure.ac File configure.ac (right): https://codereview.appspot.com/571420055/diff/571400046/configure.ac#newcode391 configure.ac:391: ["(Using Ghostscript >= 9.20 together with Extract PDFmark"]) On ...
4 years, 3 months ago (2020-01-25 09:19:27 UTC) #2
hahnjo
https://codereview.appspot.com/571420055/diff/571400046/configure.ac File configure.ac (right): https://codereview.appspot.com/571420055/diff/571400046/configure.ac#newcode391 configure.ac:391: ["(Using Ghostscript >= 9.20 together with Extract PDFmark"]) On ...
4 years, 3 months ago (2020-01-26 20:22:37 UTC) #3
Dan Eble
On 2020/01/26 20:22:37, hahnjo wrote: > Do you want me to make this change? I ...
4 years, 3 months ago (2020-01-27 01:58:15 UTC) #4
lemzwerg
> > Do you want me to make this change? > > I don't have ...
4 years, 3 months ago (2020-01-27 06:21:49 UTC) #5
hahnjo
4 years, 3 months ago (2020-01-27 07:34:32 UTC) #6
rebase and adapt message
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b