Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1631)

Issue 571210043: Issue 5629: Staff_symbol clean-up (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by Dan Eble
Modified:
4 years, 4 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5629/ 1: Reduce unnecessary access to line-positions property In some places, Staff_symbol had already checked line-positions before calling line_count (), which checked it again. 2: Remove unused Staff_symbol::line_count () and Staff_symbol_referencer::line_count () 3: Use ly_scm2floatvector () in Staff_symbol::line_positions () 4: Make height of a no-line staff [0, 0] rather than empty This fixes a bug in the output of input/regression/rest-positioning.ly, in which a staff-group bracket failed to extend to a no-line staff.

Patch Set 1 : Remove unnecessary access to line-positions property #

Patch Set 2 : Remove unused Staff_symbol::line_count () #

Patch Set 3 : Use ly_scm2floatvector () in Staff_symbol::line_positions () #

Patch Set 4 : Make height of a no-line staff [0, 0] rather than empty #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -41 lines) Patch
M lily/include/staff-symbol.hh View 1 1 chunk +3 lines, -1 line 0 comments Download
M lily/include/staff-symbol-referencer.hh View 1 1 chunk +0 lines, -1 line 0 comments Download
M lily/staff-symbol.cc View 1 2 3 5 chunks +21 lines, -32 lines 0 comments Download
M lily/staff-symbol-referencer.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4
Dan Eble
Remove unused Staff_symbol::line_count ()
4 years, 4 months ago (2019-12-06 17:15:12 UTC) #1
Dan Eble
Use ly_scm2floatvector () in Staff_symbol::line_positions ()
4 years, 4 months ago (2019-12-06 17:15:54 UTC) #2
Dan Eble
Make height of a no-line staff [0, 0] rather than empty
4 years, 4 months ago (2019-12-06 17:16:34 UTC) #3
lemzwerg
4 years, 4 months ago (2019-12-06 18:29:07 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b