Issue 5707046: Remove references to nonexistent file SkImageDecoder_libpvjpeg.c from gyp

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5707046: Remove references to nonexistent file SkImageDecoder_libpvjpeg.c from gyp (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by TomH

Modified:
12 years, 8 months ago

Reviewers:
epoger, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

code.google.com/p/skia/issues/detail?id=286. Mike removed src/images/SkImageDecoder_libpvjpeg.c from the repository on 1 June 2011 as "dead/abandoned"; surely we can get rid of the references now?

Patch Set 1 #

Patch Set 2 : Remove accidental upload #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	gyp/images.gyp	View		3 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

epoger

LGTM All those references that you removed are just "DON'T depend on this file" references ...

12 years, 8 months ago (2012-02-28 16:42:30 UTC) #3

Thanks. Closed in r3275.

Expand All Messages | Collapse All Messages