Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(534)

Issue 5704055: Implemented SSSE3 version of S32_{opaque,alpha}_D32_filter_DXDY (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by Jin A.Yang
Modified:
12 years, 7 months ago
Reviewers:
reed1, TomH
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Implemented SSSE3 version of S32_{opaque,alpha}_D32_filter_DXDY based on the current SSSE3 framework. Below are the benchmark data: Original: bench.exe -config 8888 -match bitmap_888 -rotate -for ceFilter 1 -forceBlend 0 -repeat 200 skia bench: alpha=0xFF antialias=1 filter=1 rotate=1 scale=0 clip=0 dither=defau lt strokeWidth=none scalar=float system=WIN32 running bench [640 480] bitmap_8888_update 8888: cmsecs = 118.87 running bench [640 480] bitmap_8888_update_volatile 8888: cmsecs = 117.94 running bench [640 480] bitmap_8888 8888: cmsecs = 118.48 running bench [640 480] bitmap_8888_A 8888: cmsecs = 126.44 bench.exe -config 8888 -match bitmap_888 -rotate -for ceFilter 1 -forceBlend 1 -repeat 200 skia bench: alpha=0x80 antialias=1 filter=1 rotate=1 scale=0 clip=0 dither=defau lt strokeWidth=none scalar=float system=WIN32 running bench [640 480] bitmap_8888_update 8888: cmsecs = 132.91 running bench [640 480] bitmap_8888_update_volatile 8888: cmsecs = 130.88 running bench [640 480] bitmap_8888 8888: cmsecs = 129.64 running bench [640 480] bitmap_8888_A 8888: cmsecs = 131.35 SSSE3 version: bench.exe -config 8888 -match bitmap_888 -rotate -for ceFilter 1 -forceBlend 0 -repeat 200 skia bench: alpha=0xFF antialias=1 filter=1 rotate=1 scale=0 clip=0 dither=defau lt strokeWidth=none scalar=float system=WIN32 running bench [640 480] bitmap_8888_update 8888: cmsecs = 82.91 running bench [640 480] bitmap_8888_update_volatile 8888: cmsecs = 82.60 running bench [640 480] bitmap_8888 8888: cmsecs = 83.30 running bench [640 480] bitmap_8888_A 8888: cmsecs = 90.25 bench.exe -config 8888 -match bitmap_888 -rotate -for ceFilter 1 -forceBlend 1 -repeat 200 skia bench: alpha=0x80 antialias=1 filter=1 rotate=1 scale=0 clip=0 dither=defau lt strokeWidth=none scalar=float system=WIN32 running bench [640 480] bitmap_8888_update 8888: cmsecs = 109.12 running bench [640 480] bitmap_8888_update_volatile 8888: cmsecs = 107.33 running bench [640 480] bitmap_8888 8888: cmsecs = 107.17 running bench [640 480] bitmap_8888_A 8888: cmsecs = 108.11 We can observe about 30% boost for rotated image drawing. For the HTML5 benchmark with Chromium in the below: http://demos.hacks.mozilla.org/openweb/HWACCEL/ The FPS can boost from 69 to 91. committed in http://code.google.com/p/skia/source/detail?r=3331

Patch Set 1 #

Patch Set 2 : fix the nit #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -0 lines) Patch
src/core/SkBitmapProcState.h View 1 chunk +4 lines, -0 lines 0 comments Download
src/opts/SkBitmapProcState_opts_SSSE3.h View 1 chunk +6 lines, -0 lines 0 comments Download
src/opts/SkBitmapProcState_opts_SSSE3.cpp View 1 4 chunks +226 lines, -0 lines 1 comment Download
src/opts/opts_check_SSE2.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Jin A.Yang
12 years, 8 months ago (2012-02-29 09:10:01 UTC) #1
Jin A.Yang
fix the nit
12 years, 8 months ago (2012-02-29 09:17:44 UTC) #2
Jin A.Yang
Hi Tom, Please help this patch based on SSSE3 when you have time, thanks! Jin
12 years, 8 months ago (2012-03-06 03:30:08 UTC) #3
TomH
LGTM. Awesome! Committed as r3331. http://codereview.appspot.com/5704055/diff/2002/src/opts/SkBitmapProcState_opts_SSSE3.cpp File src/opts/SkBitmapProcState_opts_SSSE3.cpp (right): http://codereview.appspot.com/5704055/diff/2002/src/opts/SkBitmapProcState_opts_SSSE3.cpp#newcode600 src/opts/SkBitmapProcState_opts_SSSE3.cpp:600: __m128i alpha; OK, normally ...
12 years, 8 months ago (2012-03-06 14:59:27 UTC) #4
TomH
It looks like this patch works fine on Windows + Linux, but may be rendering ...
12 years, 8 months ago (2012-03-06 15:39:39 UTC) #5
TomH
Rerunning that buildbot it seems to have succeeded; we'll leave this intact for now, but ...
12 years, 8 months ago (2012-03-06 16:08:07 UTC) #6
Jin A.Yang
On 2012/03/06 16:08:07, TomH wrote: > Rerunning that buildbot it seems to have succeeded; we'll ...
12 years, 8 months ago (2012-03-07 02:29:14 UTC) #7
TomH
12 years, 7 months ago (2012-03-15 17:41:55 UTC) #8
All good; please close when you get a chance.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b