Issue 5704050: code review 5704050: go/build: move code around

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5704050: code review 5704050: go/build: move code around (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by rsc

Modified:
12 years, 1 month ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

go/build: move code around Only copy+paste here. Will make next code review's diffs a bit smaller.

Patch Set 1 #

Patch Set 2 : diff -r eabeb88b4bb7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r eabeb88b4bb7 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 08554467526f https://go.googlecode.com/hg/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+716 lines, -720 lines)			Patch
M	src/pkg/go/build/build.go	View	1	1 chunk	+716 lines, -2 lines	0 comments	Download
R	src/pkg/go/build/dir.go	View	1	1 chunk	+0 lines, -705 lines	0 comments	Download
M	src/pkg/go/build/path.go	View	1	2 chunks	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 1 month ago (2012-02-28 21:25:58 UTC) #1

bradfitz

LGTM On Feb 29, 2012 8:26 AM, <rsc@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > > Message: ...

12 years, 1 month ago (2012-02-28 21:30:41 UTC) #2

rsc

12 years, 1 month ago (2012-02-28 21:34:46 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=2be444b4df80 ***

go/build: move code around

Only copy+paste here.
Will make next code review's diffs a bit smaller.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5704050

Expand All Messages | Collapse All Messages