Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(342)

Issue 5703047: Remove obsolete SVG project from gyp files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by TomH
Modified:
12 years, 10 months ago
Reviewers:
reed, epoger
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

(Either/or reviewer request) http://code.google.com/p/skia/issues/detail?id=434 Step 1 of the task in issue #434 is to remove svg and animator from builds. animator is used by views is used by SampleApp, so we can't do a trivial mass deprecation of it; this patch just stops building svg as a first step toward moving it out of the trunk repository.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/iOSSampleApp.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3
TomH
12 years, 10 months ago (2012-02-28 18:55:20 UTC) #1
epoger
LGTM , but the patch description is confusing (talks about animator, not svg)
12 years, 10 months ago (2012-02-28 19:01:01 UTC) #2
TomH
12 years, 10 months ago (2012-02-28 19:03:24 UTC) #3
On 2012/02/28 19:01:01, epoger wrote:
> LGTM , but the patch description is confusing (talks about animator, not svg)

Done. Committed in r3279.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b