AddressSanitizer: Make GetOSVersion available on all platforms

[kcc1, 2012-02-29 15:31:51]

http://codereview.appspot.com/5702060/diff/1/asan_interceptors.cc
File asan_interceptors.cc (right):

http://codereview.appspot.com/5702060/diff/1/asan_interceptors.cc#newcode623
asan_interceptors.cc:623: if (GetOSVersion() == MACOS_LION) {
Do you have any other reason for this function except for this if statement? 
For this statement, I would prefer something like 
  if (PlatformHasDifferentMemcpyAndMemmove)


BTW, Maybe it's better to implement internal_memcpy?
(It will have to be highly performant)

[samsonov, 2012-02-29 21:04:49]

http://codereview.appspot.com/5702060/diff/1/asan_interceptors.cc
File asan_interceptors.cc (right):

http://codereview.appspot.com/5702060/diff/1/asan_interceptors.cc#newcode623
asan_interceptors.cc:623: if (GetOSVersion() == MACOS_LION) {
On 2012/02/29 15:31:51, kcc1 wrote:
> Do you have any other reason for this function except for this if statement? 
Yes, it probably helps to flatten code, remove some ifdefs in favor of ifs. I
don't like the idea of OS-specific functions and headers (we currently have
asan_mac.h, we may get rid of it this way).

> For this statement, I would prefer something like 
>   if (PlatformHasDifferentMemcpyAndMemmove)
I think we may end up with too much flags/functions of that kind.
if (PlatformNeedsGetPcSpBp)? 
> 
> 
> BTW, Maybe it's better to implement internal_memcpy?
> (It will have to be highly performant)
Why do we need this? Not a problem, of course.

[kcc1, 2012-03-01 23:24:28]

> > For this statement, I would prefer something like 
> >   if (PlatformHasDifferentMemcpyAndMemmove)
> I think we may end up with too much flags/functions of that kind.
> if (PlatformNeedsGetPcSpBp)? 

I see no problem with this. 

> > 
> > 
> > BTW, Maybe it's better to implement internal_memcpy?
> > (It will have to be highly performant)
> Why do we need this? Not a problem, of course.
Maybe we don't need it.