Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14426)

Issue 5702044: code review 5702044: doc/style.css: make selectors more selective. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by Stefan Nilsson
Modified:
12 years, 1 month ago
Reviewers:
CC:
golang-dev, gri, adg
Visibility:
Public.

Description

doc/style.css: make selectors more selective. Change #foo to div#foo to avoid selecting headings with anchor foo, such as <h1 id="foo">. (A more extensive change would be to use class selectors for styling. Perhaps this is better, since id:s should be unique within a document according to http://www.w3.org/TR/CSS2/selector.html#id-selectors)

Patch Set 1 #

Patch Set 2 : diff -r bf0768b1dece https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bf0768b1dece https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -56 lines) Patch
M doc/style.css View 1 6 chunks +56 lines, -56 lines 0 comments Download

Messages

Total messages: 5
Stefan Nilsson
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 1 month ago (2012-02-28 10:09:11 UTC) #1
gri
R=adg On Tue, Feb 28, 2012 at 2:09 AM, <trolleriprofessorn@gmail.com> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
12 years, 1 month ago (2012-02-28 19:08:20 UTC) #2
adg
LGTM
12 years, 1 month ago (2012-02-28 22:36:54 UTC) #3
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=2d7f9ec6c3dc *** doc/style.css: make selectors more selective. Change #foo to div#foo to ...
12 years, 1 month ago (2012-02-28 22:39:05 UTC) #4
Stefan Nilsson
12 years, 1 month ago (2012-03-14 12:27:37 UTC) #5
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b