Issue 5700086: SkDeferredCanvas optimization: removing unnecessary conditional on all API calls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5700086: SkDeferredCanvas optimization: removing unnecessary conditional on all API calls (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by junov1

Modified:
12 years, 5 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : previous patch was wrong and incomplete #

Patch Set 3 : fixing init code #

Total comments: 1

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -44 lines)			Patch
	M	include/utils/SkDeferredCanvas.h	View	1	1 chunk	+2 lines, -2 lines	1 comment	Download
	M	src/utils/SkDeferredCanvas.cpp	View	1 2	15 chunks	+44 lines, -42 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

lgtm w/ suggested comment http://codereview.appspot.com/5700086/diff/3002/include/utils/SkDeferredCanvas.h File include/utils/SkDeferredCanvas.h (left): http://codereview.appspot.com/5700086/diff/3002/include/utils/SkDeferredCanvas.h#oldcode296 include/utils/SkDeferredCanvas.h:296: bool fDeferredDrawing; // This points ...

12 years, 9 months ago (2012-02-28 13:15:17 UTC) #2

fixed with r3268

Expand All Messages | Collapse All Messages