Issue 5699084: fix reorder initialization warning

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5699084: fix reorder initialization warning (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by guanqun

Modified:
12 years, 9 months ago

Reviewers:
DerekS

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

fix reorder initialization warning ../bench/PicturePlaybackBench.cpp: In constructor ‘PosTextPlaybackBench::PosTextPlaybackBench(void*, bool)’: ../bench/PicturePlaybackBench.cpp:133:10: warning: ‘PosTextPlaybackBench::fDrawPosH’ will be initialized after [-Wreorder] ../bench/PicturePlaybackBench.cpp:98:69: warning: base ‘PicturePlaybackBench’ [-Wreorder] ../bench/PicturePlaybackBench.cpp:96:5: warning: when initialized here [-Wreorder] BUG= TEST=compiled without the above warning

Patch Set 1 #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	bench/PicturePlaybackBench.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

guanqun.lu_gmail.com

I don't have commit rights, please help land this CL. Thanks! On Mon, Feb 27, ...

12 years, 9 months ago (2012-02-27 14:24:09 UTC) #3

Committed revision 3264.

Please mark this bug as closed.

Expand All Messages | Collapse All Messages