Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 5698072: draw circle directly via GPU shader (alternative approach) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by guanqun
Modified:
13 years, 3 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

This CL takes a bottom-up approach. It tries to GUESS whether a path is a circle or not. More description, please see https://codereview.appspot.com/5696086/ draw circle directly via GPU shader BUG= TEST=add circle test in PathTest and it improves the performance of http://themaninblue.com/experiment/AnimationBenchmark/canvas/ and http://ie.microsoft.com/testdrive/Performance/Fireworks/Default.html a lot.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -12 lines) Patch
M include/core/SkPath.h View 1 chunk +5 lines, -0 lines 0 comments Download
M include/core/SkPoint.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/core/SkPath.cpp View 3 chunks +111 lines, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 4 chunks +96 lines, -7 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 3 chunks +15 lines, -4 lines 0 comments Download
M tests/PathTest.cpp View 2 chunks +84 lines, -0 lines 0 comments Download

Messages

Total messages: 2
guanqun
Please review as well. Thanks!
13 years, 3 months ago (2012-02-27 07:31:29 UTC) #1
guanqun
13 years, 3 months ago (2012-02-28 06:11:52 UTC) #2
Close it. Track only one issue instead of two...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b