Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(345)

Issue 5698051: In convex path renderer, translate polygon to origin for fanPt computation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by bsalomon
Modified:
13 years ago
Reviewers:
guanqun.lu, guanqun, reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : remove unnecessary mod #

Patch Set 4 : use SkFloatToScalar in convex paths gm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -10 lines) Patch
M gm/convexpaths.cpp View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 2 2 chunks +25 lines, -10 lines 0 comments Download

Messages

Total messages: 6
bsalomon
This is an alternate CL that fixes the same issue as: http://codereview.appspot.com/5672069/ (Skia Issue 497) ...
13 years ago (2012-02-23 18:36:57 UTC) #1
reed1
http://codereview.appspot.com/5698051/diff/2001/src/gpu/GrAAConvexPathRenderer.cpp File src/gpu/GrAAConvexPathRenderer.cpp (right): http://codereview.appspot.com/5698051/diff/2001/src/gpu/GrAAConvexPathRenderer.cpp#newcode76 src/gpu/GrAAConvexPathRenderer.cpp:76: pi = pj; do we need the '% count' ...
13 years ago (2012-02-23 18:45:20 UTC) #2
bsalomon
http://codereview.appspot.com/5698051/diff/2001/src/gpu/GrAAConvexPathRenderer.cpp File src/gpu/GrAAConvexPathRenderer.cpp (right): http://codereview.appspot.com/5698051/diff/2001/src/gpu/GrAAConvexPathRenderer.cpp#newcode76 src/gpu/GrAAConvexPathRenderer.cpp:76: pi = pj; On 2012/02/23 18:45:21, reed1 wrote: > ...
13 years ago (2012-02-23 18:50:27 UTC) #3
reed1
lgtm
13 years ago (2012-02-23 19:09:24 UTC) #4
bsalomon
Committed as r3241. guanqun, thanks for finding this and suggesting a fix. Please let me ...
13 years ago (2012-02-23 19:21:04 UTC) #5
guanqun
13 years ago (2012-02-24 01:37:34 UTC) #6
I understand your concerns to use "double" on all architectures. Thanks for your
new fixup. It solves the problem.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b