This is an alternate CL that fixes the same issue as: http://codereview.appspot.com/5672069/ (Skia Issue 497) ...
12 years, 9 months ago
(2012-02-23 18:36:57 UTC)
#1
This is an alternate CL that fixes the same issue as:
http://codereview.appspot.com/5672069/ (Skia Issue 497)
I did some timings of both. There is no measurable difference on my Linux
machine but I'm a little hesitant to promote to double on all architectures.
An interesting note: The issue doesn't reproduce on Windows. We use more
aggressive fp optimization flags there. I believe that intermediate values are
kept in higher precision registers rather than truncated. Setting -ffast-math on
Linux makes the issue much better with the original code.
http://codereview.appspot.com/5698051/diff/2001/src/gpu/GrAAConvexPathRenderer.cpp File src/gpu/GrAAConvexPathRenderer.cpp (right): http://codereview.appspot.com/5698051/diff/2001/src/gpu/GrAAConvexPathRenderer.cpp#newcode76 src/gpu/GrAAConvexPathRenderer.cpp:76: pi = pj; do we need the '% count' ...
12 years, 9 months ago
(2012-02-23 18:45:20 UTC)
#2
Issue 5698051: In convex path renderer, translate polygon to origin for fanPt computation
(Closed)
Created 12 years, 9 months ago by bsalomon
Modified 12 years, 9 months ago
Reviewers: reed1, guanqun.lu_gmail.com, guanqun
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 2