Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(267)

Issue 5697077: code review 5697077: tutorial: delete (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by r
Modified:
12 years, 1 month ago
Reviewers:
CC:
golang-dev, bradfitz, r2, adg
Visibility:
Public.

Description

tutorial: delete Instead we'll point people at the Tour and beef up code.html. Fixes issue 3107.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 0e8f0096e631 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0ea926cdbb36 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3055 lines) Patch
M doc/Makefile View 1 chunk +0 lines, -1 line 0 comments Download
M doc/docs.html View 3 chunks +3 lines, -10 lines 0 comments Download
M doc/effective_go.html View 1 2 chunks +5 lines, -3 lines 0 comments Download
M doc/effective_go.tmpl View 1 2 chunks +5 lines, -3 lines 0 comments Download
M doc/go_for_cpp_programmers.html View 1 1 chunk +3 lines, -2 lines 0 comments Download
R doc/go_tutorial.html View 1 chunk +0 lines, -1452 lines 0 comments Download
R doc/go_tutorial.tmpl View 1 chunk +0 lines, -1040 lines 0 comments Download
M doc/install-source.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M doc/makehtml View 1 chunk +1 line, -1 line 0 comments Download
R doc/progs/cat.go View 1 chunk +0 lines, -47 lines 0 comments Download
R doc/progs/cat_rot13.go View 1 chunk +0 lines, -91 lines 0 comments Download
R doc/progs/echo.go View 1 chunk +0 lines, -32 lines 0 comments Download
R doc/progs/file.go View 1 chunk +0 lines, -77 lines 0 comments Download
R doc/progs/file_windows.go View 1 chunk +0 lines, -77 lines 0 comments Download
M doc/progs/run View 3 chunks +0 lines, -58 lines 0 comments Download
R doc/progs/sieve.go View 1 chunk +0 lines, -38 lines 0 comments Download
R doc/progs/sieve1.go View 1 chunk +0 lines, -51 lines 0 comments Download
R doc/progs/sortmain.go View 1 chunk +0 lines, -68 lines 0 comments Download
M doc/talks/go_talk-20100323.html View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/godoc/main.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
12 years, 1 month ago (2012-02-28 01:56:52 UTC) #1
bradfitz
LGTM can't go wrong with deleting On Tue, Feb 28, 2012 at 12:56 PM, <r@golang.org> ...
12 years, 1 month ago (2012-02-28 01:57:40 UTC) #2
r2
Fixes issue 3107.
12 years, 1 month ago (2012-02-28 01:59:05 UTC) #3
adg
http://codereview.appspot.com/5697077/diff/1/doc/effective_go.tmpl File doc/effective_go.tmpl (right): http://codereview.appspot.com/5697077/diff/1/doc/effective_go.tmpl#newcode30 doc/effective_go.tmpl:30: It augments the <a href="go_spec.html">language specification</a>, Do we want ...
12 years, 1 month ago (2012-02-28 02:00:21 UTC) #4
r
Hello golang-dev@googlegroups.com, bradfitz@golang.org, r@google.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 1 month ago (2012-02-28 02:08:31 UTC) #5
adg
LGTM
12 years, 1 month ago (2012-02-28 02:28:26 UTC) #6
r
12 years, 1 month ago (2012-02-28 02:36:03 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=b8e3e5d3622d ***

tutorial: delete
Instead we'll point people at the Tour and beef up code.html.

Fixes issue 3107.

R=golang-dev, bradfitz, r, adg
CC=golang-dev
http://codereview.appspot.com/5697077
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b