Issue 5696087: code review 5696087: text/template: fix redefinition bugs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5696087: code review 5696087: text/template: fix redefinition bugs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by r

Modified:
12 years, 1 month ago

Reviewers:
adg

CC:
golang-dev, adg

Visibility:
Public.

Description

text/template: fix redefinition bugs

Patch Set 1 #

Patch Set 2 : diff -r 72c47bc5652a https://code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -9 lines)			Patch
M	src/pkg/text/template/multi_test.go	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/text/template/parse/parse.go	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/text/template/parse/parse_test.go	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/text/template/template.go	View	2 chunks	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 1 month ago (2012-02-27 07:07:06 UTC) #1

12 years, 1 month ago (2012-02-28 03:24:01 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=9fa2b8dc359b ***

text/template: fix redefinition bugs

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/5696087

Expand All Messages | Collapse All Messages