Issue 5696074: code review 5696074: os: fix NetBSD build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5696074: code review 5696074: os: fix NetBSD build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bsiegert

Modified:
12 years, 2 months ago

Reviewers:
rsc

CC:
golang-dev, m4dh4tt3r, r

Visibility:
Public.

Description

os: fix NetBSD build os.fileStat.Sys is no longer exported.

Patch Set 1 #

Patch Set 2 : diff -r 0fa62412dbdd https://go.googlecode.com/hg #

Patch Set 3 : diff -r 0fa62412dbdd https://go.googlecode.com/hg #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/os/stat_netbsd.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bsiegert

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

12 years, 2 months ago (2012-02-25 17:07:47 UTC) #1

m4dh4tt3r

On 2012/02/25 17:07:47, bsiegert wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...

12 years, 2 months ago (2012-02-26 03:54:57 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=9d337b04e5cb *** os: fix NetBSD build os.fileStat.Sys is no longer exported. R=golang-dev, ...

12 years, 2 months ago (2012-02-28 00:26:05 UTC) #4

rsc

12 years, 2 months ago (2012-02-28 16:53:37 UTC) #5

On Sat, Feb 25, 2012 at 22:54,  <m4dh4tt3r@gmail.com> wrote:
> Thanks for this and the other one. However, I already have these in my
> tree, and after talking to Russ, we decided to wait until after Go1 is
> released to submit patches for NetBSD support.

Like I said to ality for Plan 9, if you have trivial little things
like this that
just keep NetBSD from falling further behind, I am happy to apply them.
I want to put off making NetBSD better until after Go 1, but I don't want
to make it worse in the process.

Russ

Expand All Messages | Collapse All Messages