code review 5696065: go.crypto/ssh: improve support for MAC algorithms

go.crypto/ssh: improve support for MAC algorithms

Also, add support for hmac-sha1.

At the suggestion of AGL hmac-md5, and hmac-md5-96
support was not included.

Fixes issue 3095.

[dave_cheney.net, 2012-02-25 10:15:04]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.crypto

[agl1, 2012-02-26 21:06:01]

LGTM although, before landing, I'd like to confirm that MD5 is actually
seriously useful to someone. Technically, HMAC-MD5 is still standing but its
lower floors are now on fire.

[dave_cheney.net, 2012-02-26 21:56:06]

More than happy to drop it. It was added mainly to ensure I properly supported
different hmac and key lengths. 

I can resubmit the CL tonight. 

On 27/02/2012, at 8:06, agl@golang.org wrote:

> LGTM although, before landing, I'd like to confirm that MD5 is actually
> seriously useful to someone. Technically, HMAC-MD5 is still standing but
> its lower floors are now on fire.
> 
> http://codereview.appspot.com/5696065/

[dave_cheney.net, 2012-02-27 09:47:43]

Hello golang-dev@googlegroups.com, agl@golang.org (cc:
golang-dev@googlegroups.com, huin@google.com),

Please take another look.

[dave_cheney.net, 2012-02-27 09:48:48]

Thanks for your comments. Patch set 6 removes the previous addition of hmac-md5
variants (their addition is simple for anyone wanting that functionality)

[huin-google, 2012-02-27 09:52:38]

LGTM. Thanks for adding this.

[dave_cheney.net, 2012-02-27 09:53:07]

On 2012/02/27 09:52:38, huin-google wrote:
> LGTM. Thanks for adding this.

Not a problem, I followed your well thought out example in cipher.go

[agl1, 2012-02-28 00:41:20]

*** Submitted as
http://code.google.com/p/go/source/detail?r=91ccd0bd392e&repo=crypto ***

go.crypto/ssh: improve support for MAC algorithms

Also, add support for hmac-sha1.

At the suggestion of AGL hmac-md5, and hmac-md5-96
support was not included.

Fixes issue 3095.

R=golang-dev, agl, huin
CC=golang-dev
http://codereview.appspot.com/5696065

Committer: Adam Langley <agl@golang.org>

http://codereview.appspot.com/5696065/diff/3007/ssh/common.go
File ssh/common.go (right):

http://codereview.appspot.com/5696065/diff/3007/ssh/common.go#newcode137
ssh/common.go:137: Macs []string
'MACs' in order to match the rest of the package. Will fix when submitting.