Issue 5695083: code review 5695083: test: bug424: wrong embedded method called

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5695083: code review 5695083: test: bug424: wrong embedded method called (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by gri

Modified:
12 years, 1 month ago

Reviewers:
rsc

CC:
golang-dev, r

Visibility:
Public.

Description

test: bug424: wrong embedded method called

Patch Set 1 #

Patch Set 2 : diff -r 0e8f0096e631 https://code.google.com/p/go #

Patch Set 3 : diff -r 0e8f0096e631 https://code.google.com/p/go #

Patch Set 4 : diff -r b8e3e5d3622d https://code.google.com/p/go #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -0 lines)			Patch
A	test/bugs/424.go	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
A	test/bugs/424.dir/lib.go	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
A	test/bugs/424.dir/main.go	View	1	1 chunk	+61 lines, -0 lines	0 comments	Download
M	test/golden.out	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 1 month ago (2012-02-28 02:29:44 UTC) #1

gri

*** Submitted as http://code.google.com/p/go/source/detail?r=72c47bc5652a *** test: bug424: wrong embedded method called R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5695083

12 years, 1 month ago (2012-02-28 02:52:42 UTC) #3

rsc

,s/424/bug424/g in the file names. See ../fixedbugs for examples.

12 years, 1 month ago (2012-02-28 17:02:27 UTC) #4

Will fix names when I move them to fixedbugs.

Expand All Messages | Collapse All Messages