code review 5694100: text/template: add example showing use of custom function

text/template: add example showing use of custom function

[r, 2012-02-28 04:11:39]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[r, 2012-02-28 04:13:49]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2012-02-28 04:16:11]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2012-02-28 04:28:14]

http://codereview.appspot.com/5694100/diff/1003/src/pkg/text/template/example...
File src/pkg/text/template/examplefunc_test.go (right):

http://codereview.appspot.com/5694100/diff/1003/src/pkg/text/template/example...
src/pkg/text/template/examplefunc_test.go:16: // Make Title Text Look Good In
Our Template;s Output.
s/;/'/

http://codereview.appspot.com/5694100/diff/1003/src/pkg/text/template/example...
src/pkg/text/template/examplefunc_test.go:18: // First we create a FuncMap with
which to register the function.
Maybe say that this is where we give it the name "title", which we use to refer
to this function inside templates.

http://codereview.appspot.com/5694100/diff/1003/src/pkg/text/template/example...
src/pkg/text/template/examplefunc_test.go:29: templateText := "Input: {{printf
`%q` .}};\n"
const templateText = `
...
` ?

[r, 2012-02-28 04:34:30]

Hello golang-dev@googlegroups.com, adg@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[adg, 2012-02-28 04:39:10]

LGTM except

http://codereview.appspot.com/5694100/diff/5005/src/pkg/text/template/example...
File src/pkg/text/template/examplefunc_test.go (right):

http://codereview.appspot.com/5694100/diff/5005/src/pkg/text/template/example...
src/pkg/text/template/examplefunc_test.go:44: err = tmpl.Execute(os.Stdout, "the
go programming language")
no handling of this error?

[r, 2012-02-28 04:50:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=e3e2423b9e6f ***

text/template: add example showing use of custom function

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/5694100