Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(376)

Issue 5688059: Build: Remove .PRECIOUS flags. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by Julien Rioux
Modified:
12 years, 2 months ago
Reviewers:
Graham Percival, dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Build: Remove .PRECIOUS flags. Since 820c7ff5d380e8ca52057717ab3176b5e40107fd all files are treated as .SECONDARY files. This means that `make' will not delete files that it identifies as intermediate files, which would be it's default behavior otherwise. Currently, lexer and parser files, some font files, and some postscript files are treated as .PRECIOUS in the build. This means that `make' will never delete these files, even when the rule for creating them failed. It seems that these files were flagged as .PRECIOUS in order to keep them around after a successful build, preventing `make' from removing them. But treating these files as .SECONDARY is sufficient for this purpose. The .PRECIOUS flag introduces potential problems that we would rather avoid. Ref: http://www.mail-archive.com/lilypond-devel@gnu.org/msg42916.html

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M lily/GNUmakefile View 1 chunk +0 lines, -6 lines 0 comments Download
M make/mutopia-targets.make View 1 chunk +0 lines, -3 lines 0 comments Download
M mf/GNUmakefile View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Julien Rioux
Please review.
12 years, 2 months ago (2012-02-21 10:11:35 UTC) #1
Graham Percival
LGTM. If David agrees, then I support pushing this to staging immediately.
12 years, 2 months ago (2012-02-21 10:36:08 UTC) #2
dak
On 2012/02/21 10:36:08, Graham Percival wrote: > LGTM. If David agrees, then I support pushing ...
12 years, 2 months ago (2012-02-21 11:03:36 UTC) #3
Julien Rioux
12 years, 2 months ago (2012-02-22 13:58:32 UTC) #4
On 2012/02/21 11:03:36, dak wrote:
> This patch removes .PRECIOUS declarations.  I don't see that it adds any
> .SECONDARY declarations.
> 
> What's up with that?

The .SECONDARY flag is already in master, in the file make/stepmake.make, since
the committish that I gave in the description.  Every Makefile that I modified
to remove .PRECIOUS already include the file make/stepmake.make, thus .SECONDARY
is already in effect.

Regards,
Julien
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b