Issue 5685062: change appendf() to more proper append()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5685062: change appendf() to more proper append() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by guanqun

Modified:
13 years ago

Reviewers:
yangsu, Steve VanDeBogart, bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

change appendf() to more proper append() checked with the following script: git grep "appendf" | grep -v "%" BUG= TEST=

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -15 lines)			Patch
M	bench/TextBench.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	experimental/Debugger/SkDebugDumper.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/utils/SkDumpCanvas.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/WArrayTest.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 2

guanqun

I noticed the not-so-perfect usages of appendf() when there are no va args. Change it ...

13 years ago (2012-02-21 03:31:30 UTC) #1

LGTM - committed as r3225