Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(63)

Issue 5683048: code review 5683048: misc/dist/windows: ongoing dev (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by Joe Poirier
Modified:
12 years, 2 months ago
Reviewers:
CC:
golang-dev, bradfitz, bradfitzgoog
Visibility:
Public.

Description

misc/dist/windows: ongoing dev Embedded Go images in the installer dialog and banner boxes, Go tree cloning uses version info from the Go tool (readme updated), the installer allows up/down-grading and reparing of the version that's installed, added two registry values.

Patch Set 1 #

Patch Set 2 : diff -r 8ce97b044cfa https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2a74f9121ce0 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 2a74f9121ce0 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 2a74f9121ce0 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 2a74f9121ce0 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 2a74f9121ce0 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -25 lines) Patch
M misc/dist/windows/README View 1 2 3 chunks +11 lines, -4 lines 0 comments Download
M misc/dist/windows/dist.bat View 1 2 chunks +6 lines, -2 lines 0 comments Download
A misc/dist/windows/images/Banner.jpg View 1 2 3 4 5 Binary file 0 comments Download
A misc/dist/windows/images/Dialog.jpg View 1 2 3 4 5 Binary file 0 comments Download
A misc/dist/windows/images/DialogLeft.jpg View 1 2 3 4 5 Binary file 0 comments Download
A misc/dist/windows/images/gopher.ico View 1 2 3 4 Binary file 0 comments Download
M misc/dist/windows/installer.wxs View 1 2 3 4 5 8 chunks +39 lines, -19 lines 0 comments Download

Messages

Total messages: 10
Joe Poirier
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 2 months ago (2012-02-20 04:46:29 UTC) #1
bradfitz
how big are the .bmp files? codereview / email don't say. On Mon, Feb 20, ...
12 years, 2 months ago (2012-02-20 04:51:45 UTC) #2
Joe Poirier
On Sun, Feb 19, 2012 at 10:51 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > how big ...
12 years, 2 months ago (2012-02-20 04:57:31 UTC) #3
bradfitz
On Mon, Feb 20, 2012 at 3:56 PM, Joseph Poirier <jdpoirier@gmail.com> wrote: > On Sun, ...
12 years, 2 months ago (2012-02-20 04:59:43 UTC) #4
Joe Poirier
On Sun, Feb 19, 2012 at 10:59 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > On Mon, ...
12 years, 2 months ago (2012-02-20 05:12:29 UTC) #5
Joe Poirier
On 2012/02/20 05:12:29, Joe Poirier wrote: > On Sun, Feb 19, 2012 at 10:59 PM, ...
12 years, 2 months ago (2012-02-20 05:56:43 UTC) #6
Joe Poirier
I figured out that even though the WiX image id refers to bmp (eg WixUIBannerBmp) ...
12 years, 2 months ago (2012-02-20 06:23:28 UTC) #7
bradfitzgoog
LGTM
12 years, 2 months ago (2012-02-20 06:25:25 UTC) #8
Joe Poirier
On Mon, Feb 20, 2012 at 12:25 AM, <bradfitz@google.com> wrote: > LGTM Thanks for the ...
12 years, 2 months ago (2012-02-20 06:29:17 UTC) #9
Joe Poirier
12 years, 2 months ago (2012-02-20 06:30:00 UTC) #10
*** Submitted as http://code.google.com/p/go/source/detail?r=8086095a2f8e ***

misc/dist/windows: ongoing dev

Embedded Go images in the installer dialog and
banner boxes, Go tree cloning uses version info
from the Go tool (readme updated), the installer
allows up/down-grading and reparing of the version
that's installed, added two registry values.

R=golang-dev, bradfitz, bradfitz
CC=golang-dev
http://codereview.appspot.com/5683048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b