Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3500)

Issue 567450043: Issue 5917: ly:performance-headers and \midi { after-writing } (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by Dan Eble
Modified:
3 years, 11 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5917/ Change ly:performance-header into ly:performance-headers, returning a list of visible header modules from innermost to outermost. Before, only the innermost header was provided, so the values of variables defined in outer headers were not accessible. If the \midi block defines a function called after-writing, LilyPond calls it after writing the MIDI file. Apart from its use in regression- testing ly:performance-headers, it offers a way for an advanced user to dump metadata associated with each performance. For example, the function could open a file and dump all header variables in YAML format for use in a scripted workflow where the information ends up in ID3 tags in an mp3 file.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -46 lines) Patch
A input/regression/midi-after-writing.ly View 1 chunk +43 lines, -0 lines 0 comments Download
M lily/book.cc View 1 chunk +14 lines, -9 lines 0 comments Download
M lily/include/performance.hh View 2 chunks +9 lines, -3 lines 0 comments Download
M lily/performance.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M lily/performance-scheme.cc View 1 chunk +3 lines, -16 lines 1 comment Download
M scm/midi.scm View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 2
lemzwerg
LGTM https://codereview.appspot.com/567450043/diff/555680043/lily/performance-scheme.cc File lily/performance-scheme.cc (left): https://codereview.appspot.com/567450043/diff/555680043/lily/performance-scheme.cc#oldcode31 lily/performance-scheme.cc:31: LY_DEFINE (ly_performance_set_header_x, "ly:performance-set-header!", Will this removal need a ...
3 years, 11 months ago (2020-04-18 05:53:25 UTC) #1
Dan Eble
3 years, 11 months ago (2020-04-18 11:25:51 UTC) #2
On 2020/04/18 05:53:25, lemzwerg wrote:
>
https://codereview.appspot.com/567450043/diff/555680043/lily/performance-sche...
> lily/performance-scheme.cc:31: LY_DEFINE (ly_performance_set_header_x,
> "ly:performance-set-header!",
> Will this removal need a `convert-ly` warning?

It doesn't strike me as important, but I don't have much experience with this
kind of decision.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b