Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1096)

Issue 5672085: make-engraver helper macro (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by dak
Modified:
12 years, 2 months ago
Reviewers:
carl.d.sorensen
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

make-engraver helper macro Two commits, the actual new functionality being introduced in scm/translation-functions.scm (is that the proper place?), and the rest just usages of this macro. This is an evidently upwards-compatible change.

Patch Set 1 #

Patch Set 2 : centering-markup-on-note-heads-automatically snippet adapted as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -205 lines) Patch
M Documentation/snippets/new/centering-markup-on-note-heads-automatically.ly View 1 2 chunks +18 lines, -24 lines 0 comments Download
M Documentation/snippets/new/defining-an-engraver-in-scheme-ambitus-engraver.ly View 4 chunks +20 lines, -23 lines 0 comments Download
M Documentation/snippets/new/numbers-as-easy-note-heads.ly View 2 chunks +14 lines, -16 lines 0 comments Download
M input/regression/scheme-engraver.ly View 1 chunk +38 lines, -57 lines 0 comments Download
M input/regression/scheme-engraver-instance.ly View 2 chunks +9 lines, -9 lines 0 comments Download
M input/regression/scheme-text-spanner.ly View 2 chunks +53 lines, -59 lines 0 comments Download
M ly/event-listener.ly View 2 chunks +15 lines, -17 lines 0 comments Download
M scm/translation-functions.scm View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Carl
Looks excellent to me! Makes Scheme engravers much more accessible. Thanks, Carl
12 years, 2 months ago (2012-02-18 16:19:35 UTC) #1
dak
12 years, 2 months ago (2012-02-18 16:32:56 UTC) #2
On 2012/02/18 16:19:35, Carl wrote:
> Looks excellent to me!
> 
> Makes Scheme engravers much more accessible.

Well, it is just syntactic sugar (or rather skimming).  But it would appear that
working with quoting and quasiquoting and unquoting and cons and lambda and list
even on an elementary level is rather scary to people not quite into Scheme, and
you don't have to enter "any of this nonsense" manually.  It turns out that the
commit putting this macro to use removes about as much lines as the commit
defining the macro adds.

I am not particularly happy about the discoverability.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b