Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(379)

Issue 5672069: we need extra precision in calculating center_of_mass (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by guanqun
Modified:
13 years, 3 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

we need extra precision here This is not an issue in theory, I've seen such bug in practice, please refer to the following bug for a simplified test case. BUG=http://code.google.com/p/skia/issues/detail?id=497 TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M src/gpu/GrAAConvexPathRenderer.cpp View 3 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 4
guanqun
Please review. Thanks!
13 years, 4 months ago (2012-02-16 15:05:30 UTC) #1
guanqun
Some explaination here: The simplified test case would generate 8 control points (forming a circle) ...
13 years, 4 months ago (2012-02-16 15:17:44 UTC) #2
guanqun
Sorry to bother, any comments on this bug? I've seen in revision 3216, cheapComputeDirection fallbacks ...
13 years, 4 months ago (2012-02-21 02:33:27 UTC) #3
bsalomon
13 years, 4 months ago (2012-02-21 18:20:07 UTC) #4
On 2012/02/21 02:33:27, guanqun wrote:
> Sorry to bother, any comments on this bug?
> 
> I've seen in revision 3216, cheapComputeDirection fallbacks to double
> computation as well. So I'm afraid this should be issue, right?
> 
> I've applied this patch on latest chromium, and it fixes the bug.
> 
> Thanks!

Hi I think your change is correct. I'm out of the office today. I'll be back
tomorrow and can land the change. I'm also wondering if the computation can be
reordered to avoid the underflows.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b