Issue 567090043: Issue 5661: Fix some conversion warnings in Source_file.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 567090043: Issue 5661: Fix some conversion warnings in Source_file. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 3 months ago by Dan Eble

Modified:
4 years, 3 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

https://sourceforge.net/p/testlilyissues/issues/5661/ Use ssize_t for line and column numbers in Input and Source_file. size_t might be more appropriate, but I want to focus on fixing warnings and not on checking unsigned arithmetic.

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -42 lines)			Patch
M	lily/include/input.hh	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	lily/include/source-file.hh	View	2 chunks	+7 lines, -10 lines	0 comments	Download
M	lily/input.cc	View	3 chunks	+8 lines, -7 lines	0 comments	Download
M	lily/input-scheme.cc	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	lily/parse-scm.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lily/source-file.cc	View	7 chunks	+11 lines, -10 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

lemzwerg

4 years, 3 months ago (2020-01-13 17:57:16 UTC) #1

LGTM, thanks!  And I think that `ssize_t` is a good type in general since it
allows to use the value -1 as a special flag.

Expand All Messages | Collapse All Messages