Issue 5669045: Add test to detect bias in conversion of frag shader floats to bytes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5669045: Add test to detect bias in conversion of frag shader floats to bytes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by bsalomon

Modified:
12 years, 10 months ago

Reviewers:
TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 5 : remove unneeded deletes of fbo/rb #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+286 lines, -0 lines)			Patch
M	gyp/gpu.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.h	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View		3 chunks	+4 lines, -0 lines	0 comments	Download
A	src/gpu/gl/GrGLColorConversionTest.h	View	1 2	1 chunk	+36 lines, -0 lines	0 comments	Download
A	src/gpu/gl/GrGLColorConversionTest.cpp	View	1 2 3 4	1 chunk	+238 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

TomH

LGTM http://codereview.appspot.com/5669045/diff/4001/src/gpu/gl/GrGLColorConversionTest.cpp File src/gpu/gl/GrGLColorConversionTest.cpp (right): http://codereview.appspot.com/5669045/diff/4001/src/gpu/gl/GrGLColorConversionTest.cpp#newcode17 src/gpu/gl/GrGLColorConversionTest.cpp:17: * round-to-nearest are output from the FS. After ...

12 years, 10 months ago (2012-02-14 16:22:03 UTC) #2

bsalomon

12 years, 10 months ago (2012-02-14 18:19:47 UTC) #3

Landed at r3192 (and build fixes at 3193).

http://codereview.appspot.com/5669045/diff/4001/src/gpu/gl/GrGLColorConversio...
File src/gpu/gl/GrGLColorConversionTest.cpp (right):

http://codereview.appspot.com/5669045/diff/4001/src/gpu/gl/GrGLColorConversio...
src/gpu/gl/GrGLColorConversionTest.cpp:17: * round-to-nearest are output from
the FS. After read pixels we check how the
On 2012/02/14 16:22:03, TomH wrote:
> This 2nd sentence isn't clear.

Done.

http://codereview.appspot.com/5669045/diff/4001/src/gpu/gl/GrGLColorConversio...
src/gpu/gl/GrGLColorConversionTest.cpp:19: * middle of the range we expect to
convery to i is also output.
On 2012/02/14 16:22:03, TomH wrote:
> Nit: convery (sp) == convert?

Done.

http://codereview.appspot.com/5669045/diff/4001/src/gpu/gl/GrGLColorConversio...
src/gpu/gl/GrGLColorConversionTest.cpp:230: return
kUnknown_GrGLByteColorConversion;
On 2012/02/14 16:22:03, TomH wrote:
> Should this get an assert or a debug log?

Done.

Expand All Messages | Collapse All Messages