FSA Set contentType to text/html response when creating HtmlResponseWriter.

FSA Set contentType to text/html response when creating HtmlResponseWriter.

[ejona, 2014-01-24 18:25:31]

LGTM

Note that this scared me because name() is not guaranteed to follow any
particular standard (and the difference between utf8 and utf-8 can be
important), but it looks like it generally agrees with charsets expected by
rfc2046 with names like UTF-8 and US-ASCII.

Hard-coding it would have made me feel more at ease, but this is likely to work
for most encodings that we would choose to use.

[brett.michael.johnson_gmail.com, 2014-01-24 18:45:51]

I wanted to make sure that the stated charset
was the one that was supplied to the Writer 
constructor on the previous line.  And yes,
I did verify that the canonical name of the
UTF-8 charset was, indeed, "UTF-8".

--
Brett M. Johnson

On Jan 24, 2014, at 10:25 AM, ejona@google.com wrote:

> LGTM
> 
> Note that this scared me because name() is not guaranteed to follow any
> particular standard (and the difference between utf8 and utf-8 can be
> important), but it looks like it generally agrees with charsets expected
> by rfc2046 with names like UTF-8 and US-ASCII.
> 
> Hard-coding it would have made me feel more at ease, but this is likely
> to work for most encodings that we would choose to use.
> 
> https://codereview.appspot.com/56690043/

[Brett, 2014-01-24 18:48:20]

Committed 24 January 2014

[ejona, 2014-01-24 20:09:45]

For posterity (I didn't reply correctly so it didn't make it to this issue):

On the version you used on the JRE implementation you used, it was UTF-8. That
is implementation-specific behavior. Based on parts of the documentation it
seems likely that other implementations would do the same, but it isn't
guaranteed.