Issue 566870043: Drop requirement for python-devel

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 566870043: Drop requirement for python-devel (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 6 months ago by hahnjo

Modified:
4 years, 6 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Drop requirement for python-devel The detected flags were not used (there are no C files in python/) and LilyPond compiles just fine with this change.

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -92 lines)			Patch
M	aclocal.m4	View	1 chunk	+0 lines, -83 lines	0 comments	Download
M	config.hh.in	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	config.make.in	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	configure.ac	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	python/GNUmakefile	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

lemzwerg

4 years, 6 months ago (2019-10-06 12:37:43 UTC) #1

LGTM, thanks.

The file `python/midi.c` was rewritten in Python almost three years ago, see
commit d8677d345.

Expand All Messages | Collapse All Messages