Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1039)

Issue 5665045: Move GL-specific include files to coexist alongside D3D backend (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by TomH
Modified:
12 years, 10 months ago
Reviewers:
bsalomon
CC:
reed1, epoger
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

As is typical, rietveld seems to miss some of the action (in this case, the moves of include/gpu/*GL* to include/gpu/gl/), but svn status displays them properly. This change breaks client gyps and so is unrollable.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1688 lines) Patch
M bench/BenchGpuTimer_gl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/benchmain.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/gmmain.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gyp/gpu.gyp View 2 chunks +8 lines, -8 lines 0 comments Download
D include/gpu/GrGLConfig.h View 1 chunk +0 lines, -273 lines 0 comments Download
D include/gpu/GrGLConfig_chrome.h View 1 chunk +0 lines, -37 lines 0 comments Download
D include/gpu/GrGLDefines.h View 1 chunk +0 lines, -692 lines 0 comments Download
D include/gpu/GrGLInterface.h View 1 chunk +0 lines, -429 lines 0 comments Download
D include/gpu/SkGLContext.h View 1 chunk +0 lines, -63 lines 0 comments Download
D include/gpu/SkMesaGLContext.h View 1 chunk +0 lines, -50 lines 0 comments Download
D include/gpu/SkNativeGLContext.h View 1 chunk +0 lines, -81 lines 0 comments Download
D include/gpu/SkNullGLContext.h View 1 chunk +0 lines, -27 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpuFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpuVertex.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLContextInfo.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLDefaultInterface_native.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLIRect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLIndexBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLSL.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLStencilBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLVertexBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/SkGLContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/SkNullGLContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/unix/GrGLCreateNativeInterface_unix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/unix/SkNativeGLContext_unix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLInterfaceValidation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/Test.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
TomH
12 years, 10 months ago (2012-02-14 14:40:48 UTC) #1
bsalomon
LGTM
12 years, 10 months ago (2012-02-14 15:07:00 UTC) #2
TomH
12 years, 10 months ago (2012-02-14 15:12:25 UTC) #3
Committed in r3185.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b