Make GLCaps be standalone and be a member of GrGLContextInfo

[bsalomon, 2012-02-13 20:05:10]

In which struct GrGpuGL::GLCaps is turned into a non-nested class. The code in
GrGpuGL that initializes it is extracted and moved into the new class. GrGLCaps
is made a member of GrGLContextInfo so that the shader generator will be able to
access it. (IOW this is mostly a copy/paste search/replace CL).

Future: Make GrDrawTarget::Caps also be a real class and subclass it in
GrGLCaps.

[TomH, 2012-02-13 22:06:38]

LGTM

http://codereview.appspot.com/5654084/diff/2001/src/gpu/gl/GrGLCaps.cpp
File src/gpu/gl/GrGLCaps.cpp (right):

http://codereview.appspot.com/5654084/diff/2001/src/gpu/gl/GrGLCaps.cpp#newco...
src/gpu/gl/GrGLCaps.cpp:47: fMSFBOType = caps.fMSFBOType;
Nit: OK, this is really, really trivial (nit^2?): could you keep the order of
the fields consistent in these two functions?

http://codereview.appspot.com/5654084/diff/2001/src/gpu/gl/GrGLCaps.cpp#newco...
src/gpu/gl/GrGLCaps.cpp:82: fMaxFragmentUniformVectors = 16;
Is this really a valid state? Or should we be dying?

http://codereview.appspot.com/5654084/diff/2001/src/gpu/gl/GrGLCaps.cpp#newco...
src/gpu/gl/GrGLCaps.cpp:175: // Omitting fVerifiedColorConfigs from initializer
list should init to 0.
I don't understand this sentence.

[bsalomon, 2012-02-14 14:10:55]

Checked in at r3183.

http://codereview.appspot.com/5654084/diff/2001/src/gpu/gl/GrGLCaps.cpp
File src/gpu/gl/GrGLCaps.cpp (right):

http://codereview.appspot.com/5654084/diff/2001/src/gpu/gl/GrGLCaps.cpp#newco...
src/gpu/gl/GrGLCaps.cpp:47: fMSFBOType = caps.fMSFBOType;
On 2012/02/13 22:06:38, TomH wrote:
> Nit: OK, this is really, really trivial (nit^2?): could you keep the order of
> the fields consistent in these two functions?

Done.

http://codereview.appspot.com/5654084/diff/2001/src/gpu/gl/GrGLCaps.cpp#newco...
src/gpu/gl/GrGLCaps.cpp:82: fMaxFragmentUniformVectors = 16;
On 2012/02/13 22:06:38, TomH wrote:
> Is this really a valid state? Or should we be dying?

It's not valid. Changed to:
    if (kES2_GrGLBinding == binding) {
        GR_GL_GetIntegerv(gli, GR_GL_MAX_FRAGMENT_UNIFORM_VECTORS,
                          &fMaxFragmentUniformVectors);
    } else {
        GrAssert(kDesktop_GrGLBinding == binding);
        GrGLint max;
        GR_GL_GetIntegerv(gli, GR_GL_MAX_FRAGMENT_UNIFORM_COMPONENTS, &max);
        fMaxFragmentUniformVectors = max / 4;
    }

http://codereview.appspot.com/5654084/diff/2001/src/gpu/gl/GrGLCaps.cpp#newco...
src/gpu/gl/GrGLCaps.cpp:175: // Omitting fVerifiedColorConfigs from initializer
list should init to 0.
On 2012/02/13 22:06:38, TomH wrote:
> I don't understand this sentence.

It's obsolete and now removed.