Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10737)

Issue 565320043: Issue 5310: find_top_context () instead of get_global_context () (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by Dan Eble
Modified:
4 years, 4 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5310/ Call find_top_context () rather than get_global_context () where the caller uses the result as a mere Context. This supersedes an old review that included some controversial changes: https://codereview.appspot.com/341150043/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M lily/lyric-combine-music-iterator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/score-engraver.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M lily/score-performer.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2
Dan Eble
4 years, 4 months ago (2019-12-13 00:12:16 UTC) #1
lemzwerg
4 years, 4 months ago (2019-12-13 05:06:52 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b