Issue 5652047: Pull GLSL helpers out of GrGLProgram.cpp

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5652047: Pull GLSL helpers out of GrGLProgram.cpp (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by bsalomon

Modified:
12 years, 10 months ago

Reviewers:
TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 3 : comment improvments #

Total comments: 2

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -97 lines)			Patch
M	src/gpu/GrGLProgram.cpp	View	1	8 chunks	+20 lines, -79 lines	1 comment	Download
M	src/gpu/GrGLSL.h	View	1 2	1 chunk	+48 lines, -6 lines	1 comment	Download
M	src/gpu/GrGLSL.cpp	View	1	1 chunk	+56 lines, -6 lines	0 comments	Download
M	src/gpu/GrGLShaderVar.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/gpu/GrGpuGLShaders.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

This is to facilitate creating a shader outside of GrGLProgram that follows the rules of ...

12 years, 10 months ago (2012-02-09 22:00:41 UTC) #1

TomH

LGTM. Thanks for the hint to start with the .h http://codereview.appspot.com/5652047/diff/12/src/gpu/GrGLProgram.cpp File src/gpu/GrGLProgram.cpp (right): http://codereview.appspot.com/5652047/diff/12/src/gpu/GrGLProgram.cpp#newcode699 ...

12 years, 10 months ago (2012-02-09 22:07:54 UTC) #2

bsalomon

12 years, 10 months ago (2012-02-10 15:56:52 UTC) #3

On 2012/02/09 22:07:54, TomH wrote:
> LGTM. Thanks for the hint to start with the .h
> 
> http://codereview.appspot.com/5652047/diff/12/src/gpu/GrGLProgram.cpp
> File src/gpu/GrGLProgram.cpp (right):
> 
>
http://codereview.appspot.com/5652047/diff/12/src/gpu/GrGLProgram.cpp#newcode699
> src/gpu/GrGLProgram.cpp:699:
> segments.fHeader.printf(GrGetGLSLVersionDecl(gl->fBindingsExported,
> glslGeneration));
> Nit: Line length?
> 
> http://codereview.appspot.com/5652047/diff/12/src/gpu/GrGLSL.h
> File src/gpu/GrGLSL.h (right):
> 
> http://codereview.appspot.com/5652047/diff/12/src/gpu/GrGLSL.h#newcode33
> src/gpu/GrGLSL.h:33: * Gets the GLSL Generation to use with the GL context.
> Nit: Context is a loaded word & there's no context here?

Fixed the nits and landed at 3161.

Expand All Messages | Collapse All Messages