Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1865)

Issue 5649069: path effect on a very thin line should not be discarded (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by guanqun
Modified:
12 years, 4 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

path effect on a very thin line should not be discarded This patch fixes the second line rendering in SampleApp:Slides. BUG= TEST=SampleApp Slides

Patch Set 1 #

Patch Set 2 : patchset 2 (add gm test, ported from SampleApp:Slides) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -2 lines) Patch
A gm/patheffects.cpp View 1 1 chunk +160 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8
guanqun
1. I've checked the gm output before and after this CL, there's no diff. So ...
12 years, 4 months ago (2012-02-12 10:57:59 UTC) #1
bsalomon
On 2012/02/12 10:57:59, guanqun wrote: > 1. I've checked the gm output before and after ...
12 years, 4 months ago (2012-02-13 14:28:47 UTC) #2
reed1
lgtm good catch. Does this work fine in the raster case, and was only a ...
12 years, 4 months ago (2012-02-13 14:37:57 UTC) #3
bsalomon
On 2012/02/13 14:28:47, bsalomon wrote: > On 2012/02/12 10:57:59, guanqun wrote: > > 1. I've ...
12 years, 4 months ago (2012-02-13 14:43:22 UTC) #4
guanqun
On 2012/02/13 14:37:57, reed1 wrote: > good catch. Does this work fine in the raster ...
12 years, 4 months ago (2012-02-13 14:44:21 UTC) #5
bsalomon
Landed the change at r3171
12 years, 4 months ago (2012-02-13 14:49:31 UTC) #6
guanqun
On 2012/02/13 14:49:31, bsalomon wrote: > Landed the change at r3171 Thanks for landing this ...
12 years, 4 months ago (2012-02-13 15:12:48 UTC) #7
bsalomon
12 years, 4 months ago (2012-02-13 15:18:57 UTC) #8
On 2012/02/13 15:12:48, guanqun wrote:
> On 2012/02/13 14:49:31, bsalomon wrote:
> > Landed the change at r3171
> 
> Thanks for landing this CL. But I've just uploaded a second pathset, adding
this
> gm test, it's ported from SampleApp:Slides, should I upload another request?

Thanks for the GM! I just landed it at r3172.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b