Issue 5649054: Checks to see that stencil commands have the correct number of arguments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5649054: Checks to see that stencil commands have the correct number of arguments.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by MikeSol

Modified:
12 years, 2 months ago

Reviewers:
dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Checks to see that stencil commands have the correct number of arguments.

Patch Set 1 #

Total comments: 1

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+100 lines, -53 lines)			Patch
M	lily/include/lily-guile.hh	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	lily/include/stencil.hh	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lily/lily-guile.cc	View	2 chunks	+18 lines, -0 lines	0 comments	Download
M	lily/stencil-expression.cc	View	2 chunks	+23 lines, -4 lines	1 comment	Download
M	lily/stencil-scheme.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	scm/backend-library.scm	View	1 chunk	+9 lines, -8 lines	0 comments	Download
M	scm/define-stencil-commands.scm	View	2 chunks	+42 lines, -38 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

dak

12 years, 2 months ago (2012-02-12 15:21:44 UTC) #1

http://codereview.appspot.com/5649054/diff/1/lily/stencil-expression.cc
File lily/stencil-expression.cc (right):

http://codereview.appspot.com/5649054/diff/1/lily/stencil-expression.cc#newco...
lily/stencil-expression.cc:31: nargs = scm_permanent_object (scm_cons (scm_cons
(ly_symbol2scm ("dummy"), SCM_EOL), SCM_EOL));
dummy?

The whole stuff is totally incomprehensible.  It is not clear what is stored
where and for what reason, and there is no documentation whatsoever.  It was bad
before, agreed, but it has become much worse.

Expand All Messages | Collapse All Messages