Issue 5647045: oob -> urn:ietf:wg:oauth:2.0:oob

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5647045: oob -> urn:ietf:wg:oauth:2.0:oob (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by jcgregorio_google

Modified:
12 years, 7 months ago

Reviewers:
aiuto, jcgregorio_google

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Description

Move to final (hopefully) OAuth 2.0 value for oob.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments #

Patch Set 3 : Remove spurious file. #

Patch Set 4 : remove file #

Patch Set 5 : remove file #

Patch Set 6 : Fix tests also. #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -10 lines)			Patch
M	oauth2client/client.py	View	1	2 chunks	+8 lines, -5 lines	0 comments	Download
M	oauth2client/tools.py	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/test_oauth2client.py	View	1 2 3 4 5	3 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

aiuto

Do you have to support the old style ('oob') as well for a while? http://codereview.appspot.com/5647045/diff/1/oauth2client/client.py ...

12 years, 7 months ago (2012-02-08 20:22:37 UTC) #2

jcgregorio_google

No need to keep support for 'oob' around, the servers will accept both values. http://codereview.appspot.com/5647045/diff/1/oauth2client/client.py ...

12 years, 7 months ago (2012-02-09 16:24:56 UTC) #3

jcgregorio_google

12 years, 7 months ago (2012-02-09 17:19:27 UTC) #5

On 2012/02/09 16:48:57, aiuto wrote:
> lgtm

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=a330a52a1af...

Expand All Messages | Collapse All Messages