Issue 5645083: Use GrGLContextInfo in shader generator

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5645083: Use GrGLContextInfo in shader generator (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by bsalomon

Modified:
12 years, 7 months ago

Reviewers:
TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Comitted at 3171

Patch Set 1 #

Total comments: 1

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+131 lines, -158 lines)			Patch
M	include/gpu/GrGLInterface.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/gpu/gl/GrGLContextInfo.h	View	1 chunk	+1 line, -1 line	1 comment	Download
M	src/gpu/gl/GrGLProgram.h	View	5 chunks	+9 lines, -12 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View	17 chunks	+103 lines, -113 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderVar.h	View	3 chunks	+5 lines, -9 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGpuGLShaders.cpp	View	5 chunks	+10 lines, -15 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

TomH

12 years, 7 months ago (2012-02-13 14:10:35 UTC) #2

LGTM

http://codereview.appspot.com/5645083/diff/1/src/gpu/gl/GrGLContextInfo.h
File src/gpu/gl/GrGLContextInfo.h (right):

http://codereview.appspot.com/5645083/diff/1/src/gpu/gl/GrGLContextInfo.h#new...
src/gpu/gl/GrGLContextInfo.h:35: explicit GrGLContextInfo(const GrGLInterface*
interface);
Did we have an error where we were getting unexpected "casting"? Or is this just
careful? (Good either way)

Expand All Messages | Collapse All Messages