Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(499)

Issue 5645083: Use GrGLContextInfo in shader generator (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by bsalomon
Modified:
12 years, 10 months ago
Reviewers:
TomH
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Comitted at 3171

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -158 lines) Patch
M include/gpu/GrGLInterface.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLContextInfo.h View 1 chunk +1 line, -1 line 1 comment Download
M src/gpu/gl/GrGLProgram.h View 5 chunks +9 lines, -12 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 17 chunks +103 lines, -113 lines 0 comments Download
M src/gpu/gl/GrGLShaderVar.h View 3 chunks +5 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGLShaders.cpp View 5 chunks +10 lines, -15 lines 0 comments Download

Messages

Total messages: 2
bsalomon
12 years, 10 months ago (2012-02-10 22:38:22 UTC) #1
TomH
12 years, 10 months ago (2012-02-13 14:10:35 UTC) #2
LGTM

http://codereview.appspot.com/5645083/diff/1/src/gpu/gl/GrGLContextInfo.h
File src/gpu/gl/GrGLContextInfo.h (right):

http://codereview.appspot.com/5645083/diff/1/src/gpu/gl/GrGLContextInfo.h#new...
src/gpu/gl/GrGLContextInfo.h:35: explicit GrGLContextInfo(const GrGLInterface*
interface);
Did we have an error where we were getting unexpected "casting"? Or is this just
careful? (Good either way)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b