Issue 5645055: Add SK_API to SkTableColorFilter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5645055: Add SK_API to SkTableColorFilter (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by dmazzoni

Modified:
11 years, 11 months ago

Reviewers:
Steve VanDeBogart, thakis

CC:
skia-dev_google.com

Base URL:
http://skia.googlecode.com/svn/trunk/include/

Visibility:
Public.

More Reviews

Description

Add SK_API to SkTableColorFilter to export it so that it can be used by Chromium. Chromium bug: http://crbug.com/112944

Patch Set 1 #

Total comments: 2

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	effects/SkTableColorFilter.h	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Steve VanDeBogart

LGTM - Committed as r3153. Watch for the roll.

12 years, 10 months ago (2012-02-08 17:02:37 UTC) #2

thakis

http://codereview.appspot.com/5645055/diff/1/effects/SkTableColorFilter.h File effects/SkTableColorFilter.h (right): http://codereview.appspot.com/5645055/diff/1/effects/SkTableColorFilter.h#newcode7 effects/SkTableColorFilter.h:7: class SK_API SkTableColorFilter { I added this just to ...

12 years, 10 months ago (2012-02-10 21:12:58 UTC) #3

thakis

…for some reason, this appeared in my gmail just now. It looks like this change ...

12 years, 10 months ago (2012-02-10 21:13:28 UTC) #4

Steve VanDeBogart

12 years, 10 months ago (2012-02-10 21:19:08 UTC) #5

http://codereview.appspot.com/5645055/diff/1/effects/SkTableColorFilter.h
File effects/SkTableColorFilter.h (right):

http://codereview.appspot.com/5645055/diff/1/effects/SkTableColorFilter.h#new...
effects/SkTableColorFilter.h:7: class SK_API SkTableColorFilter {
On 2012/02/10 21:12:59, thakis wrote:
> I added this just to CreateARGB() yesterday (skia r3160,
> https://codereview.appspot.com/5642073/). Are you sure you need this change?

It was added to support https://chromiumcodereview.appspot.com/9353012/ , so
probably not.  But AFAIK, the Skia policy is to add SK_API to the class name
where possible to minimize the number of SK_API's in the code.

Expand All Messages | Collapse All Messages