Issue 5645045: Explicitly say that everything is OK at the end of the 'test' rule

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5645045: Explicitly say that everything is OK at the end of the 'test' rule (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 12 months ago by timurrrr_at_google_com

Modified:
12 years, 10 months ago

Reviewers:
kcc1

CC:
llvm-commits_cs.uiuc.edu, glider, samsonov

Base URL:
http://llvm.org/svn/llvm-project/compiler-rt/trunk/lib/asan/

Visibility:
Public.

Description

Committed http://llvm.org/viewvc/llvm-project?view=rev&revision=149990

Patch Set 1 #

Created: 12 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	Makefile.old	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

timurrrr_at_google_com

Hi, Can you please review this tiny patch? While testing ASan with "-j" I've noticed ...

12 years, 12 months ago (2012-02-07 14:32:22 UTC) #1

kcc1

12 years, 12 months ago (2012-02-07 17:40:30 UTC) #2

r149990, thanks!

On Tue, Feb 7, 2012 at 6:32 AM, <timurrrr@google.com> wrote:

> Reviewers: kcc1,
>
> Message:
> Hi,
>
> Can you please review this tiny patch?
>
> While testing ASan with "-j" I've noticed that intermediate test
> failures are very hard to notice.
> I think it's good to have an explicit green light sign at the end of
> "make test"
>
> Thanks,
> Timur
>
>
>
> Please review this at
http://codereview.appspot.com/**5645045/<http://codereview.appspot.com/5645045/>
>
> Affected files:
>  M     Makefile.old
>
>
> Index: Makefile.old
> ==============================**==============================**=======
> --- Makefile.old        (revision 149985)
> +++ Makefile.old        (working copy)
> @@ -205,6 +205,7 @@
>  all: b64 b32
>
>  test: t64 t32 output_tests lint
> +       @echo "ALL TESTS PASSED"
>
>  output_tests: b32 b64
>        cd tests && ./test_output.sh $(CLANG_CXX) $(CLANG_CC)
>
>
>

Expand All Messages | Collapse All Messages