Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1226)

Issue 5644048: code review 5644048: fmt: diagnose invalid verb applied to pointer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by rsc
Modified:
12 years, 1 month ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

fmt: diagnose invalid verb applied to pointer Fixes issue 2851.

Patch Set 1 #

Patch Set 2 : diff -r 915676d75024 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 915676d75024 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 915676d75024 https://code.google.com/p/go/ #

Patch Set 5 : diff -r c5594074a09a https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -18 lines) Patch
M src/pkg/fmt/fmt_test.go View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M src/pkg/fmt/print.go View 1 2 3 4 chunks +12 lines, -18 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 1 month ago (2012-02-07 22:48:50 UTC) #1
r
LGTM
12 years, 1 month ago (2012-02-07 23:38:20 UTC) #2
rsc
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 1 month ago (2012-02-08 04:32:25 UTC) #3
r
LGTM
12 years, 1 month ago (2012-02-08 04:36:37 UTC) #4
rsc
12 years, 1 month ago (2012-02-08 04:37:09 UTC) #5
*** Submitted as 73fbf2edae3d ***

fmt: diagnose invalid verb applied to pointer

Fixes issue 2851.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5644048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b