Issue 5643070: start from zero so we can test bitmap as well

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5643070: start from zero so we can test bitmap as well (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by guanqun

Modified:
12 years, 11 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

start from zero so we can test bitmap as well BUG= TEST=./out/Debug/tests passed.

Patch Set 1 #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tests/ReadPixelsTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

guanqun

Is there any specific reason why we bypassed the test reading pixels from bitmap? If ...

12 years, 11 months ago (2012-02-09 05:57:42 UTC) #1

bsalomon

12 years, 11 months ago (2012-02-09 13:55:49 UTC) #2

On 2012/02/09 05:57:42, guanqun wrote:
> Is there any specific reason why we bypassed the test reading pixels from
> bitmap?
> 
> If no, I'd like to add it back. It's tested and it can pass.
> 
> Please review. thanks!

Nope, I had set it to 1 when I first wrote the test to debug and never put it
back to 0. Landed at 3156.

Expand All Messages | Collapse All Messages