Issue 5643050: code review 5643050: 5l, 6l, 8l: implement -X flag

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5643050: code review 5643050: 5l, 6l, 8l: implement -X flag (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by rsc

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Patch Set 2 : diff -r 77df677f85a4 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 77df677f85a4 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 77df677f85a4 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 77df677f85a4 https://go.googlecode.com/hg/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -130 lines)			Patch
M	src/cmd/5l/doc.go	View	1 2 3	1 chunk	+3 lines, -29 lines	0 comments	Download
M	src/cmd/5l/obj.c	View	1 2	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/cmd/6l/doc.go	View	1 2 3	1 chunk	+3 lines, -42 lines	0 comments	Download
M	src/cmd/6l/obj.c	View	1	4 chunks	+5 lines, -4 lines	0 comments	Download
M	src/cmd/8l/doc.go	View	1 2 3	1 chunk	+3 lines, -44 lines	0 comments	Download
M	src/cmd/8l/obj.c	View	1 2	4 chunks	+5 lines, -4 lines	0 comments	Download
M	src/cmd/ld/data.c	View	1 2 3	1 chunk	+19 lines, -0 lines	0 comments	Download
M	src/cmd/ld/doc.go	View	1 2 3	1 chunk	+44 lines, -2 lines	0 comments	Download
M	src/cmd/ld/lib.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	test/linkx.go	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 2 months ago (2012-02-07 20:58:25 UTC) #1

iant

Documentation? http://codereview.appspot.com/5643050/diff/4001/src/cmd/ld/data.c File src/cmd/ld/data.c (right): http://codereview.appspot.com/5643050/diff/4001/src/cmd/ld/data.c#newcode607 src/cmd/ld/data.c:607: if(thechar == '6') s/thechar == '6'/PtrSize ==8/ ?

12 years, 2 months ago (2012-02-07 21:29:10 UTC) #3

rsc

> s/thechar == '6'/PtrSize ==8/ ? There it is! I was grepping for ptr.

12 years, 2 months ago (2012-02-07 21:29:36 UTC) #4

rsc

Hello golang-dev@googlegroups.com, iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 2 months ago (2012-02-07 21:34:53 UTC) #5

rsc

12 years, 2 months ago (2012-02-07 21:46:35 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=915676d75024 ***

5l, 6l, 8l: implement -X flag

R=golang-dev, iant
CC=golang-dev
http://codereview.appspot.com/5643050

Expand All Messages | Collapse All Messages