Issue 5642056: code review 5642056: net/http/httputil: preserve query params in reverse proxy

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5642056: code review 5642056: net/http/httputil: preserve query params in reverse proxy (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bradfitz

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

net/http/httputil: preserve query params in reverse proxy Fixes issue 2853

Patch Set 2 : diff -r c90b59861968 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r 320932bfe991 https://go.googlecode.com/hg/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -1 line)			Patch
	M	src/pkg/net/http/httputil/reverseproxy.go	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
	M	src/pkg/net/http/httputil/reverseproxy_test.go	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 2 months ago (2012-02-08 01:50:57 UTC) #1

LGTM http://codereview.appspot.com/5642056/diff/3/src/pkg/net/http/httputil/reverseproxy.go File src/pkg/net/http/httputil/reverseproxy.go (right): http://codereview.appspot.com/5642056/diff/3/src/pkg/net/http/httputil/reverseproxy.go#newcode63 src/pkg/net/http/httputil/reverseproxy.go:63: if targetQuery != "" && req.URL.RawQuery != "" ...

12 years, 2 months ago (2012-02-08 01:54:20 UTC) #2

bradfitz

12 years, 2 months ago (2012-02-08 02:00:37 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e6f4226bfc5c ***

net/http/httputil: preserve query params in reverse proxy

Fixes issue 2853

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5642056

Expand All Messages | Collapse All Messages