LGTM On Tue, Feb 7, 2012 at 3:41 PM, <r@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
12 years, 2 months ago
(2012-02-07 23:51:12 UTC)
#2
LGTM
On Tue, Feb 7, 2012 at 3:41 PM, <r@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> bug408: delete
> It's disabled and unreproducible.
>
> Please review this at
http://codereview.appspot.com/**5642053/<http://codereview.appspot.com/5642053/>
>
> Affected files:
> R test/fixedbugs/bug408.go
>
>
> Index: test/fixedbugs/bug408.go
> ==============================**==============================**=======
> deleted file mode 100644
> --- a/test/fixedbugs/bug408.go
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -// true
> -
> -// WAS: errchk cgo $D/$F.go
> -// but this fails (cgo succeeds) on OS X Snow Leopard
> -// with Xcode 4.2 and gcc version 4.2.1 (Based on Apple Inc. build 5658)
> (LLVM build 2336.1.00).
> -
> -// Copyright 2012 The Go Authors. All rights reserved.
> -// Use of this source code is governed by a BSD-style
> -// license that can be found in the LICENSE file.
> -
> -// Issue 1800: cgo not reporting line numbers.
> -
> -package main
> -
> -// #include <stdio.h>
> -import "C"
> -
> -func f() {
> - C.printf(nil) // ERROR "go:15.*unexpected type"
> -}
>
>
>
Issue 5642053: code review 5642053: bug408: delete
(Closed)
Created 12 years, 2 months ago by r
Modified 12 years, 2 months ago
Reviewers:
Base URL:
Comments: 0