Issue 5639046: code review 5639046: flag: describe valid input for Duration flags.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5639046: code review 5639046: flag: describe valid input for Duration flags. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by dsymonds

Modified:
13 years, 3 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

flag: describe valid input for Duration flags.

Patch Set 2 : diff -r 7c35ab6ef473 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7c35ab6ef473 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r f7a090be42f5 https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/pkg/flag/flag.go	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2012-02-07 06:07:05 UTC) #1

LGTM http://codereview.appspot.com/5639046/diff/3001/src/pkg/flag/flag.go File src/pkg/flag/flag.go (right): http://codereview.appspot.com/5639046/diff/3001/src/pkg/flag/flag.go#newcode52 src/pkg/flag/flag.go:52: Duration flags accept input that is accepted by ...

13 years, 3 months ago (2012-02-07 06:46:59 UTC) #2

dsymonds

13 years, 3 months ago (2012-02-07 06:50:11 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=fae148fab2a7 ***

flag: describe valid input for Duration flags.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5639046

http://codereview.appspot.com/5639046/diff/3001/src/pkg/flag/flag.go
File src/pkg/flag/flag.go (right):

http://codereview.appspot.com/5639046/diff/3001/src/pkg/flag/flag.go#newcode52
src/pkg/flag/flag.go:52: Duration flags accept input that is accepted by
time.ParseDuration.
On 2012/02/07 06:46:59, r wrote:
> doubled "accept". maybe
> Duration flags accept any input valid for time.ParseDuration.

Done.

Expand All Messages | Collapse All Messages